@AngularClass their solution is more elegant imo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo6104
suggested changes
Mar 30, 2017
| let headNode: any; | ||
|
|
||
| // tslint:disable-next-line:no-inferrable-types | ||
| for (let i: number = 0; i < document.childNodes.length; ++i) { |
There was a problem hiding this comment.
I think this code can be simplify with .some method
document.childNodes.some(child => isTag('html', child) && !!(rootNode = child));
| } | ||
|
|
||
| // tslint:disable-next-line:no-inferrable-types | ||
| for (let i: number = 0; i < rootNode.childNodes.length; ++i) { |
There was a problem hiding this comment.
this for loop also can be
rootNode.childNodes.some(child => isTag('head', child) && !!(headNode = child));
There was a problem hiding this comment.
To sum up, 2 for loop code can be simplified to
let rootNode: any = document;
let headNode: any;
// tslint:disable-next-line:no-inferrable-types
document.childNodes.some(child => isTag('html', child) && !!(rootNode = child));
// tslint:disable-next-line:no-inferrable-types
rootNode.childNodes.some(child => isTag('head', child) && !!(headNode = child));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.