Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPT-9 Build multi-platform Docker images #16

Merged
merged 22 commits into from
Jun 5, 2024

Conversation

borna-ng
Copy link

No description provided.

Copy link
Author

@borna-ng borna-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Benniphx

This works but the pipeline is taking too long (almost 3 hours 😮).

It prevents us from properly iterating and we simply cannot afford that. I wouldn't merge this PR before that issue is addressed.

@borna-ng borna-ng force-pushed the jobrad-multi-architecture branch 21 times, most recently from e7d6eac to 794102f Compare May 31, 2024 11:01
@borna-ng
Copy link
Author

borna-ng commented May 31, 2024

GitHub's ARM64 runners are already virtualized and they do not support nested virtualization (link). I assume that's the reason we cannot run Docker or Podman that require an additional virtualization layer on MacOS. We would need either a Linux ARM64 runner or a native non-virtualized MacOS runner.

@borna-ng borna-ng changed the title Build the multiarchitecture Docker image CPT-9 Build the multiarchitecture Docker image Jun 3, 2024
@borna-ng borna-ng self-assigned this Jun 4, 2024
@borna-ng
Copy link
Author

borna-ng commented Jun 4, 2024

Building the Python wheel for libsass is disgustingly slow 😅

@borna-ng borna-ng changed the title CPT-9 Build the multiarchitecture Docker image CPT-9 Build multi-platform Docker images Jun 4, 2024
@Benniphx Benniphx marked this pull request as ready for review June 5, 2024 11:17
@Benniphx Benniphx merged commit 9b14c8a into jobrad-14.0 Jun 5, 2024
3 checks passed
@Benniphx Benniphx deleted the jobrad-multi-architecture branch June 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants