If the object to be encrypted is a ciphertext, it makes the command an error. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eri-fukuda
reviewed
Oct 20, 2017
| func alreadyEncryptErrorTestRun(t *testing.T, tester *encrypterTester, tests map[string]testInput) error { | ||
| for key, _ := range tests { | ||
| err := tester.encrypter.Encrypt("", fmt.Sprintf("%s/%v", tester.COPY_TEST_DIR, key)) | ||
| if err != nil { |
There was a problem hiding this comment.
How about excluding this error handling?
Since test cases is clear, it is considered that no error will occur.
There was a problem hiding this comment.
Sounds like a good idea.
Once we make another issue, and I think I will fix it.
eri-fukuda
approved these changes
Oct 23, 2017
na-o-ys
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #83
If the object to be encrypted is a ciphertext, it makes the command an error.
changes
About implementation
The already encrypted file has encryption information as meta information.
Specifically, it has the key "encryption_type".
Therefore, those with "encryption_type" are considered to be encrypted.