This repository has been archived by the owner on Jun 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Patch for Discord Electron Security Update (e.g. Canary currently) #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random fixes
Merge master changes to beta
ED itself and most of the built in plugins are working again. - ED Settings functional - Injection not crashing - Only hidden channels has obvious issue - Devtools custom warning text still broken - Stable support not harmed so far - Due to Discord's electron security updates (which is why a breaking patch was needed in the first place), remote module is no longer relied on by ED, and plugins can no longer use it. (as of now)
Addresses Issue #143 |
…ebpack stuff - Still can't get it to wait till webpack is definitely done, so expect it to sometimes not complete loading ED.
Additions to description since, so others can know:
|
Attempt was made at resolving such issue. |
Well, that failed |
Partially repaired BD Plugin compatibility (stuff like the on switch event, still isn't properly handled) |
This was referenced Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ED itself and most of the built in plugins are working again.
attempt made to fix this issue(failed)second attempt made to fix this issue(failed)