Skip to content
This repository has been archived by the owner on Jun 27, 2021. It is now read-only.

Patch for Discord Electron Security Update (e.g. Canary currently) #155

Merged
merged 12 commits into from
Feb 9, 2021

Conversation

MasicoreLord
Copy link
Contributor

@MasicoreLord MasicoreLord commented Feb 6, 2021

ED itself and most of the built in plugins are working again.

  • ED Settings functional.
  • Injection not crashing.
  • Hidden channels mostly works, except no server settings option.
  • Devtools custom warning text still broken.
  • Stable support not harmed so far.
  • Due to Discord's electron security updates (which is why a breaking patch was needed in the first place), remote module is no longer relied on by ED, and plugins can no longer use it. (as of now).
  • BD Plugin support is broken, but was tweaked so it could fail w/o breaking some ED plugins (like ed settings) if it was enabled by the user.
    • Partial fix made (stuff like the on switch event is faulty atm)
  • ED sometimes won't load, because I had to bypass the check for webpackJsonp, due to the way I'm accessing it not working w/ the check.
    • attempt made to fix this issue (failed)
    • second attempt made to fix this issue (failed)

xirreal and others added 7 commits November 12, 2020 11:14
Merge master changes to beta
ED itself and most of the built in plugins are working again.
- ED Settings functional
- Injection not crashing
- Only hidden channels has obvious issue
- Devtools custom warning text still broken
- Stable support not harmed so far
- Due to Discord's electron security updates (which is why a breaking patch was needed in the first place), remote module is no longer relied on by ED, and plugins can no longer use it. (as of now)
@MasicoreLord
Copy link
Contributor Author

Addresses Issue #143

…ebpack stuff

- Still can't get it to wait till webpack is definitely done, so expect it to sometimes not complete loading ED.
@MasicoreLord
Copy link
Contributor Author

Additions to description since, so others can know:

  • ED sometimes won't load, because I had to bypass the check for webpackJsonp, due to the way I'm accessing it not working w/ the check.

@MasicoreLord
Copy link
Contributor Author

Additions to description since, so others can know:

  • ED sometimes won't load, because I had to bypass the check for webpackJsonp, due to the way I'm accessing it not working w/ the check.

Attempt was made at resolving such issue.

@MasicoreLord
Copy link
Contributor Author

Additions to description since, so others can know:

  • ED sometimes won't load, because I had to bypass the check for webpackJsonp, due to the way I'm accessing it not working w/ the check.

Attempt was made at resolving such issue.

Well, that failed

@MasicoreLord
Copy link
Contributor Author

Partially repaired BD Plugin compatibility (stuff like the on switch event, still isn't properly handled)

@joe27g joe27g merged commit 8acb2a0 into joe27g:beta Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants