clear rows before invoking nextRows callback #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeferner
added a commit
that referenced
this pull request
Feb 2, 2014
clear rows before invoking nextRows callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more fix for the reader.
@joeferner. Sorry for bugging you one more time with this. I hope it will be the last one on this topic.
BTW, we are getting serious into using your driver in our application and I want to thank you for the great work you put into it. I like the design because it exposes a simple callback API without unnecessary bells and whistles. There are nevertherless a number of things that we'll need to add to it, like support for missing datatypes, streaming on BLOB and CLOB, etc. So you'll probably get more PR requests from us in the coming weeks.
Bruno