Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math expressions documentation #1

Open
wants to merge 78 commits into
base: master
Choose a base branch
from

Conversation

joel-bernstein
Copy link
Owner

No description provided.

joel-bernstein and others added 30 commits February 16, 2018 21:04
The bin/solr scripts print a warning message when a user creates a
collection that makes use of the default config (which has settings
not recommended for production).

While helpful, this warning was a little too noisy.  It also suggested
users resolve the issue with a provided curl command, but bin/solr is
also capable of performing the same action.

This commit cleans up the error message a bit.
There were test failures in case inconsistent index options were introduced in
a new segment because checks were not done in the right order.
The new `-slow` switch makes checks more complete but also more heavy. This
option also cross-checks term vectors.
…cluster changes.

Wait specifically for listeners to run.
…fixed interval beginning with a given start time
The 'bin/solr assert' tool provides the capability to programmatically
test basic assertions about a running Solr instance.  Is it running on
a particular host or port?  Is it running as a specified user?  etc.

This commit adds a new type of check: the mode Solr is running in
(standalone vs. cloud).
…ns on a fixed interval beginning with a given start time"

This reverts commit 137e647
…ssure to

relocate replicas - in some test runs the policy decided not to move any replicas.
joel-bernstein pushed a commit that referenced this pull request May 9, 2019
… SimClusterStateProvider/SimCloudManager

There are 3 tightly related bug fixes in these changes:

1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when
   creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed
   to use synchronizedList wrappers.
2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking
   the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape
   would timeout regardless of how long they waited.)   To protect against "silent" failures like this,
   this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors
   will be logged and "counted."  SimSolrCloudTestCase will ensure a suite level failure if any such failures
   are counted.
3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election:
   These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of
   replicas when the Callables were created vs when they were later run -- notably a Callable may have been
   created that held a reference to a Slice, but by the time that Callable was run the collection (or a
   node, etc...) refered to by that Slice may have been deleted.  While fixing this, the leader election
   logic was also cleaned up such that adding a replica only triggers leader election for that shard, not
   every shard in the collection.

While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was
also cleaned up to remove all risky points where an exception may have been possible after aquiring the
lock but before the try/finally that ensured it would be unlocked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.