forked from apache/lucene-solr
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math expressions documentation #1
Open
joel-bernstein
wants to merge
78
commits into
master
Choose a base branch
from
math_expressions_documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bin/solr scripts print a warning message when a user creates a collection that makes use of the default config (which has settings not recommended for production). While helpful, this warning was a little too noisy. It also suggested users resolve the issue with a provided curl command, but bin/solr is also capable of performing the same action. This commit cleans up the error message a bit.
…ndler's dataConfig request parameter
There were test failures in case inconsistent index options were introduced in a new segment because checks were not done in the right order.
…eldType (spellcheck)
…kens" This reverts commit 972df6c.
…60.2" This reverts commit d99bfa4.
This reverts commit 07407a5.
This reverts commit a31a8da.
This reverts commit 4bfcbc5.
The new `-slow` switch makes checks more complete but also more heavy. This option also cross-checks term vectors.
…cluster changes. Wait specifically for listeners to run.
…fixed interval beginning with a given start time
The 'bin/solr assert' tool provides the capability to programmatically test basic assertions about a running Solr instance. Is it running on a particular host or port? Is it running as a specified user? etc. This commit adds a new type of check: the mode Solr is running in (standalone vs. cloud).
…ns on a fixed interval beginning with a given start time" This reverts commit 137e647
…ssure to relocate replicas - in some test runs the policy decided not to move any replicas.
…aces --no-fetch cmdline option
joel-bernstein
pushed a commit
that referenced
this pull request
May 9, 2019
… SimClusterStateProvider/SimCloudManager There are 3 tightly related bug fixes in these changes: 1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed to use synchronizedList wrappers. 2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape would timeout regardless of how long they waited.) To protect against "silent" failures like this, this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors will be logged and "counted." SimSolrCloudTestCase will ensure a suite level failure if any such failures are counted. 3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election: These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of replicas when the Callables were created vs when they were later run -- notably a Callable may have been created that held a reference to a Slice, but by the time that Callable was run the collection (or a node, etc...) refered to by that Slice may have been deleted. While fixing this, the leader election logic was also cleaned up such that adding a replica only triggers leader election for that shard, not every shard in the collection. While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was also cleaned up to remove all risky points where an exception may have been possible after aquiring the lock but before the try/finally that ensured it would be unlocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.