Skip to content

Conversation

mtkp
Copy link
Contributor

@mtkp mtkp commented Nov 10, 2018

  • allow dynamic bindings to be used from within a hystrix command.
  • refactor mdc propagation using a similar pattern to thread binding frame.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2acbd65 on mtkp:binding-frame into 950c67c on joelittlejohn:master.

@joelittlejohn
Copy link
Owner

I really like this change. These two problems (no binding conveyance and no MDC conveyance) always take a little time to surface, but sooner or later they are identified whenever we write code that uses a Java library that manages its own executors. Then some manual conveyance of these two things is implemented. Great to have this sorted in the library.

@joelittlejohn joelittlejohn merged commit 143d5f5 into joelittlejohn:master Nov 11, 2018
@mtkp
Copy link
Contributor Author

mtkp commented Nov 12, 2018

thanks @joelittlejohn !

@mtkp mtkp deleted the binding-frame branch November 12, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants