Adding support for repeated URL parameters. #86
Merged
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is legal for a URL parameter to be repeated multiple times in the query string with different values. The previous code was only using the first occurence of the parameter when normalizing the URL, which ultimately causes a signature mismatch.
|
I'm seeing this issue as well -- has this been merged? |
|
Please add this, it's definitely needed to use this library. |
joestump
added a commit
that referenced
this pull request
Jul 29, 2015
Adding support for repeated URL parameters.
This was referenced Jul 29, 2015
Closed
Closed
Closed
|
@joestump is this fixed or does it need verification? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is legal for a URL parameter to be repeated multiple times in the
query string with different values. The previous code was only using
the first occurence of the parameter when normalizing the URL, which
ultimately causes a signature mismatch.