Fix wrong subprocess call

[rakjin]

As you know, subprocess.call has some specific requirements on shell and the type of args.

• https://docs.python.org/2/library/subprocess.html#frequently-used-arguments

On my windows machine with MINGW32:

>>> import subprocess
>>> subprocess.call(['ls', '-l'], shell=False)
total 0
-rw-r--r--  1 grampush  Administ  0  6 24 01:15 a.out
-rw-r--r--  1 grampush  Administ  0  6 24 01:14 sample.wav
-rw-r--r--  1 grampush  Administ  0  6 24 01:15 zigbee.bin
0
>>> subprocess.call(['ls', '-l'], shell=True)
-rw-r--r--  1 grampush  Administ  0  6 24 01:15 a.out
-rw-r--r--  1 grampush  Administ  0  6 24 01:14 sample.wav
-rw-r--r--  1 grampush  Administ  0  6 24 01:15 zigbee.bin
0
>>> 

However, on OS X:

>>> import subprocess
>>> subprocess.call(['ls', '-l'], shell=False)
total 0
-rw-r--r--  1 grampush  staff  0  6 24 01:15 a.out
-rw-r--r--  1 grampush  staff  0  6 24 01:14 sample.wav
-rw-r--r--  1 grampush  staff  0  6 24 01:15 zigbee.bin
0
>>> subprocess.call(['ls', '-l'], shell=True)
a.out       sample.wav  zigbee.bin
0
>>> 

Only the first item of args is applied to the actual execution, in this case.

I think we should do: call(a_list, shell=False) or call(a_str, shell=True)

[joeyespo]

Went with the fix in #18. Going to run some tests to make sure this still works on Windows, but that should take care of the non-Windows cases. Does that fix work for you too?

[rakjin]

#18 works for win7 and OS X both, in my case. also I learnt about subprocess.mswindows 👍