Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename later to fromNow to clarify the origin time #8

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

jporsay
Copy link
Contributor

@jporsay jporsay commented Oct 15, 2019

Using .later doesn't leave clear what the origin time is.
Renamed it to .fromNow to clarify that the time is a delta time starting from DateTime.now().

3rd party examples:
moment.js uses a similar nomenclature.
As does Ruby on Rails.

Fixes #9

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          13     13           
=====================================
  Hits           13     13
Impacted Files Coverage Δ
lib/src/extensions.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a26dbd...80ad958. Read the comment docs.

@jogboms jogboms self-requested a review October 16, 2019 06:40
@jogboms jogboms added the help wanted Extra attention is needed label Oct 16, 2019
Copy link
Owner

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jporsay
This is indeed a good catch.
Thanks, but can I ask that we keep this open for a while and pinned? As it is a grammatical and/or semantic change that may not affect as much unless needed.

@jporsay
Copy link
Contributor Author

jporsay commented Oct 16, 2019

No problem with me. Also, not quite sure why you tagged it as help-wanted when the changes have already been done ;)

@jogboms
Copy link
Owner

jogboms commented Oct 20, 2019

Yeah, I want more eyes to see this but apparently PR's don't work that way.

@jogboms jogboms removed the help wanted Extra attention is needed label Oct 20, 2019
@jogboms jogboms changed the base branch from master to 1.1.0 October 29, 2019 05:55
@jogboms jogboms merged commit 568695a into jogboms:1.1.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants