-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 plugin revamp #99
Conversation
…nal option, migrate dryRun to dry
…ns renamed to cleanAfterEveryBuildPatterns
This looks great! Thank you for putting in the work on this @chrisblossom 🎉 |
Yes I think we should. Should I change the version from Also, I'll need you to sign up and add to the github repo circleci.com, appveyor and codecov.io. Let me know if you use a different username than I think this should all be done before publishing to NPM. |
|
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=========================================
Coverage ? 98.64%
=========================================
Files ? 1
Lines ? 74
Branches ? 25
=========================================
Hits ? 73
Misses ? 1
Partials ? 0
Continue to review full report at Codecov.
|
Thanks for getting that done! With CircleCI, you'll want to turn on Do you want to release a |
done! Let's go with |
Can you add me to the AppVeyor team? My username is chrisblossom, email cbloss@gmail.com. I just want to be able to re-run builds. Looks like CircleCI already lets me because I'm a github collaborator for this repo. If you want help maintaining the npm version, my npm username is chrisblossom. I'm going to go ahead and merge this in. Once you push to NPM, I'll close the issues/PRs I linked in this PR. |
Wow, that's amazing. Phenomenal! |
Additional v2 Information
README.md
Changes:
output.path
)Additional notes:
Please discuss the current API and suggest any changes.
Closes Issues: #53 #55 #67 #73 #80 #85 #86 #89 #91 #92 #93 #98
Closes PRs: #39 #74