Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 plugin revamp #99

Merged
merged 16 commits into from Mar 4, 2019
Merged

2.0 plugin revamp #99

merged 16 commits into from Mar 4, 2019

Conversation

chrisblossom
Copy link
Collaborator

@chrisblossom chrisblossom commented Feb 23, 2019

Additional v2 Information
README.md

Changes:

  • No configuration is needed for standard usage (cleans webpack's output.path)
  • By default during webpack's watch mode, only files created by webpack are removed
  • Because del is used, globbing is supported
  • Plugin is tested directly via webpack
  • All supported versions are tested
  • Windows is tested via appveyor (no mocked tests)
  • Complete build system including prepublish hooks and git prepush/commit hooks
  • Written with Typescript

Additional notes:

Please discuss the current API and suggest any changes.

Closes Issues: #53 #55 #67 #73 #80 #85 #86 #89 #91 #92 #93 #98
Closes PRs: #39 #74

@johnagan
Copy link
Owner

johnagan commented Mar 3, 2019

This looks great! Thank you for putting in the work on this @chrisblossom 🎉
Should we merge this into master and push to npm?

@chrisblossom
Copy link
Collaborator Author

Yes I think we should. Should I change the version from 2.0.0-alpha1 to 2.0.0?

Also, I'll need you to sign up and add to the github repo circleci.com, appveyor and codecov.io. Let me know if you use a different username than johnagan for any of the services so I can update the readme links.

I think this should all be done before publishing to NPM.

@johnagan
Copy link
Owner

johnagan commented Mar 4, 2019

add to the github repo circleci.com, appveyor and codecov.io.

@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2778115). Click here to learn what that means.
The diff coverage is 98.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage          ?   98.64%           
=========================================
  Files             ?        1           
  Lines             ?       74           
  Branches          ?       25           
=========================================
  Hits              ?       73           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
src/clean-webpack-plugin.ts 98.64% <98.64%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2778115...ab33153. Read the comment docs.

@chrisblossom
Copy link
Collaborator Author

Thanks for getting that done!

With CircleCI, you'll want to turn on Settings > Build Settings > Advanced Settings > Build forked pull requests.

Do you want to release a @next 2.0.0-alpha1 version or go straight into 2.0.0? I think releasing this as 2.0.0 will get the most/quickest feedback and since del's force option is disabled by default, it will not remove any files outside of a project. Also their webpack config will throw an error because the API has completely changed.

@johnagan
Copy link
Owner

johnagan commented Mar 4, 2019

With CircleCI, you'll want to turn on Settings > Build Settings > Advanced Settings > Build forked pull requests.

done!

Let's go with 2.0.0 and see how it goes

@chrisblossom
Copy link
Collaborator Author

Can you add me to the AppVeyor team? My username is chrisblossom, email cbloss@gmail.com. I just want to be able to re-run builds.

Looks like CircleCI already lets me because I'm a github collaborator for this repo. If you want help maintaining the npm version, my npm username is chrisblossom.

I'm going to go ahead and merge this in. Once you push to NPM, I'll close the issues/PRs I linked in this PR.

@chrisblossom chrisblossom merged commit 4c3146b into johnagan:master Mar 4, 2019
@chrisblossom chrisblossom changed the title Proposed plugin revamp 2.0 plugin revamp Mar 4, 2019
@stereokai
Copy link

Wow, that's amazing. Phenomenal!

@chrisblossom chrisblossom deleted the 2.0 branch March 5, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants