Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of INVENTORY section, with headings #32

Closed
MomoMoses opened this issue Oct 5, 2021 · 7 comments
Closed

Display of INVENTORY section, with headings #32

MomoMoses opened this issue Oct 5, 2021 · 7 comments

Comments

@MomoMoses
Copy link
Collaborator

Example is the ACLU Illinois (Uchicago) collection. https://bmrcportal-test.lib.uchicago.edu/view/?id=BMRC.UOC.ACLU_IL.xml#idp61012480

Above the "Series I" as well as the Subseries sections, it's not necessary to put the heading "Title". For reference, here's how it appears on the UChicago site:
Subseries 1: Administration and Finance
Box 1 Folder 1-2 Access Reports, 1971-1978
Box 1 Folder 3 ACLU Executive Director's Conference, June 12-15, 1975
.....

Label for "Series I: Administration" should stand out more, and definitely would not be less noticeable than the scope and content note for the series below. It's good that the Label for the Series note is different than the label for the Overview scope and content note though.

@johnjung
Copy link
Owner

johnjung commented Oct 6, 2021

I need to figure out which situations I should display labels in...please let me know if you'd like to try the following approach:

  1. Display did elements that include containers like table-rows. In this case, elements other than containers are collected in the rightmost column where each element gets a label, like "title".
  2. When did elements do NOT include containers, display each child as its own one-cell row in the table-like output. (In other words, display each child as a block level element.) In this case, do not generate labels.

(1) is already happening- the difference in (2) is that in situations like the one you mentioned above, labels like "title" won't appear. Most of the children of did elements are unittitle, unitdate, and unitid elements, so hopefully they will be understandable without labels.

Please let me know if you want to try it like this.

The second part of this is balancing the visual weight of things like "Scope and Content" and "Series I: Administration" in your example. This is a little trickier, so I'd like to split that out into a separate issue once we've finished this part.

@MomoMoses
Copy link
Collaborator Author

MomoMoses commented Oct 6, 2021 via email

@johnjung
Copy link
Owner

johnjung commented Oct 8, 2021

Ok- the first part of this is now live in the portal test server. Here's the commit.

Please let me know if this looks ok. If so we can move onto the second part.

@johnjung
Copy link
Owner

Also see #46.

@johnjung
Copy link
Owner

Part 2 of this looks like it's covered in issue 46. I'm going to close this out, please feel free to reopen if necessary.

@MomoMoses
Copy link
Collaborator Author

Rereading this I see that there may have been a misunderstanding. I don't think the labels need to appear in the table-row displays at all. With our without containers.

@johnjung
Copy link
Owner

Closing this issue again because I believe we have this covered in #46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants