Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly restrictive freezegun and random2 dependencies #970

Closed
timokau opened this issue Jun 19, 2019 · 4 comments · Fixed by #972
Closed

Overly restrictive freezegun and random2 dependencies #970

timokau opened this issue Jun 19, 2019 · 4 comments · Fixed by #972

Comments

@timokau
Copy link
Contributor

timokau commented Jun 19, 2019

Currently freezegun and random2 are pinned to exact versions:

faker/setup.py

Line 77 in c412d56

"random2==1.0.1",

faker/setup.py

Line 78 in c412d56

"freezegun==0.3.11",

Is there any reason for that? Would there really be problems with freezegun 0.3.12? This kind of version pinning is hard to match for distribution packagers.

@fcurella
Copy link
Collaborator

The reason we pin the dependencies is that we don't want to break the build in case one of them drops support for python 2.7. I think we can relax them and just pin to the minor version, so something like random2<1.1 and freezegun<0.4

@timokau
Copy link
Contributor Author

timokau commented Jun 19, 2019

That would be helpful, as long as they adhere to something semver-like they shouldn't drop python2 support in a minor update.

@fcurella
Copy link
Collaborator

@timokau I'm currently on vacation, so I don't have much time to work on this.

But if you could write a PR that passes the build, I should have enough time to merge and release

@timokau
Copy link
Contributor Author

timokau commented Jun 20, 2019

Sure, #972.

No big hurry though, after you vacation is also perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants