Skip to content

Conversation

Yogendra0Sharma
Copy link
Contributor

No description provided.

@bastnic
Copy link
Member

bastnic commented Oct 3, 2017

Thanks @Yogendra0Sharma !

Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for your PR, here is just some minor changes to make.

index.html Outdated
<a name="reIndexes"></a>
<h2 class="ui dividing header">Reindex API</h2>
<h3 class="ui header">Simple Reindex Operation</h3>
<pre class="es1 es2"><code>POST /_reindex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ReIndex API was not available in Elasticsearch 1, so the es1 class should not be set here. In fact the whole "reindex" part should be enclosed in a div with "es2 es5" classes.

index.html Outdated
"index": "test-index-new"
}
}</code></pre>
<pre class="es5"><code>POST /_reindex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, this example is compatible with es2 too.

index.html Outdated
"type": "female"
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your JSON is not valid here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a typo. I have resolved this issue and submitted the change. please review.

}
}</code></pre>
<h3 class="ui header">Selective Reindex Operation</h3>
<p >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the extra space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

index.html Outdated


<div class="es2 es5">
<a name="reIndexes"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we do not add an entry in the menu, this can be removed too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to add a reIndex option to the menu ? or just remove this code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this option, we don't have enough space in the menu 😬

@damienalexandre
Copy link
Member

Thanks for the JSON typo, can you look at my other comments please?

@damienalexandre damienalexandre merged commit 05b668e into jolicode:gh-pages Oct 3, 2017
@damienalexandre
Copy link
Member

✅ Hey, thank you @Yogendra0Sharma! 🙌
That's some ✨ nice documentation 👍 and I'm glad to have the opportunity to merge it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants