Fix [Issue 25]: elasticsearch download link #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahuldkjain
changed the title
|
@pyrech @damienalexandre Please review the PR |
damienalexandre
requested changes
Oct 18, 2019
There was a problem hiding this comment.
Ideally, for ES 7, it should be a link to https://www.elastic.co/downloads/elasticsearch as it's automatically the latest version (so it's quicker).
But for all the other versions your link is good 👍
Could you change this please? You have to use the classes "es1 es2" to display for Elastic 1 and 2, etc.
|
@damienalexandre made the required changes, please review again. |
damienalexandre
requested changes
Oct 18, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a download link for all versions to index.html