Parametrizable ui document interaction controller #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sending multiple requests in the same time
createJSModules was removedin React Native 0.47.0 and results in the attached Build Error. removing @OverRide fixes build (didn't remove function because I don't know if it should be kept for downard compatability?) ``` node_modules/react-native-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobPackage.java:23: error: method does not override or implement a method from a supertype @OverRide ^ 1 error Incremental compilation of 1 classes completed in 0.219 secs. :react-native-fetch-blob:compileReleaseJavaWithJavac FAILED FAILURE: Build failed with an exception. ```
refs #51397 Added parameters to UIDocumentInteractionController refs #51397 Added parameters to UIDocumentInteractionController refs #51397 Added parameters to UIDocumentInteractionController
…i_document_interaction_controller
|
Apologies for the long overdue review. There are quite a few commits on this PR that seem to be doing far more than addressing the described issue. I would be more comfortable with a more focused PR that didn't include so many seemingly unrelated commits |
halaei
pushed a commit
to halaei/rn-fetch-blob
that referenced
this pull request
Feb 2, 2022
fixes FS.df callback return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to UIDocumentInteractionController. This change allows you to change color and font type of iOS title bar.