Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind enter to view diff (but not jump into diff view) ? #83

Closed
fkater opened this issue Aug 30, 2012 · 4 comments
Closed

bind enter to view diff (but not jump into diff view) ? #83

fkater opened this issue Aug 30, 2012 · 4 comments
Labels

Comments

@fkater
Copy link

fkater commented Aug 30, 2012

Hi,

I would like to rebind the enter key: Instead of showing the diff and placing the cursor into the diff view I would like to show the diff view without placing the cursor there.

So, in ~/.tigrc, I tried: bind main enter view-diff

However, this opens the diff-view in full-screen mode. I would like to keep the split-screen, though. Is there something like:

bind main enter view-diff-in-split-screen ?

Thank you for the wonderful app
Felix

@jonas
Copy link
Owner

jonas commented Aug 30, 2012

You are not the first one to request this, but I have never gotten around to actually do the needed refactoring to allow this sort of thing. The current navigation mode is somewhat hardwired with the behavior of 'Enter' making it difficult to just add a new keybinding.

I've made a quick prototype, which I think actually works pretty natural. Enter will open the diff as you proposed, and pressing enter again on the same commit will scroll the diff view, which is similar to the behavior of the current navigation mode.

@fkater
Copy link
Author

fkater commented Aug 31, 2012

I have compiled the lazy-nav branch. Yeah, completely sufficiant for me!

Thanks a lot
Felix

@jonas
Copy link
Owner

jonas commented Oct 1, 2012

Thanks for testing this Felix. I merged the lazy-nav branch into master. To enable the lazy mode you need to add the following to ~/.tigrc:

set focus-child = no

@jonas jonas closed this as completed Oct 1, 2012
@jonas
Copy link
Owner

jonas commented Oct 1, 2012

Oh, yeah, and if you have comments, such as a better name for this option, please don't hesitate to send me a note.

koutcher added a commit that referenced this issue Feb 21, 2021
Restore #83 behaviour that was broken by dd96223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants