Add email to author, in addition to name #115

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@afb

afb commented Feb 2, 2013

Allow showing the email, instead of the name (add it to the toggle).
Left to do is a "conversion file", to show usernames of the authors.

afb added some commits Jan 31, 2013

Add email to author, in addition to name
Convert the name string to an author struct, adding the email string.
Allow showing the email, instead of the name (add it to the toggle).
Allow showing only the username of the email
Add an additional author display mode, showing the user name and not the
domain name. Left to do is a "conversion file", for emails to usernames.
Identical to what git cvsimport uses, just used in the other direction.
@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Feb 18, 2013

Owner

Hello,

I suggest that we keep a unified author cache instead of having the names and emails in separate caches.
Also, I would prefer that struct author_info becomes struct ident, which is shorter and closer to git's naming convention.

Else I like the idea a lot.

Owner

jonas commented Feb 18, 2013

Hello,

I suggest that we keep a unified author cache instead of having the names and emails in separate caches.
Also, I would prefer that struct author_info becomes struct ident, which is shorter and closer to git's naming convention.

Else I like the idea a lot.

jonas added a commit that referenced this pull request Feb 20, 2013

[#115] Add toggles for showing author email or email user names
The initial patch and idea was contributed by Anders F Björklund.
Reimplemented to use a 'single object' cache of authors.
@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Feb 20, 2013

Owner

Hello,

I went ahead and redid the patch based on my comments above. Hope you don't mind.
I am not sure what you mean by "conversion file". Is this like the mailmap file supported by git-shortlog?

Anyway, I will go ahead and close this issue.

Owner

jonas commented Feb 20, 2013

Hello,

I went ahead and redid the patch based on my comments above. Hope you don't mind.
I am not sure what you mean by "conversion file". Is this like the mailmap file supported by git-shortlog?

Anyway, I will go ahead and close this issue.

@jonas jonas closed this Feb 20, 2013

@afb

This comment has been minimized.

Show comment Hide comment
@afb

afb Feb 20, 2013

Thanks for accepting the feature!

I think the mailmap feature is more for making e.g. user@hotmail.com and user@gmail.com appear as the same author ? The display feature that I had in mind would be to show the username for places that use longer emails, instead of just user@host (domain) like traditional unix domain emails...

So for "A U Thor a.u.thor@example.com" it would show "author" instead of "a.u.thor". Or if that example looks contrived, "afb" instead of "anders.f.bjorklund". One could even imagine looking it up in LDAP, as an additional add-on feature. Anyway, same as in cvs/svn import only backwards (and for display only)

Will try your code, and open new issue(s)...

afb commented Feb 20, 2013

Thanks for accepting the feature!

I think the mailmap feature is more for making e.g. user@hotmail.com and user@gmail.com appear as the same author ? The display feature that I had in mind would be to show the username for places that use longer emails, instead of just user@host (domain) like traditional unix domain emails...

So for "A U Thor a.u.thor@example.com" it would show "author" instead of "a.u.thor". Or if that example looks contrived, "afb" instead of "anders.f.bjorklund". One could even imagine looking it up in LDAP, as an additional add-on feature. Anyway, same as in cvs/svn import only backwards (and for display only)

Will try your code, and open new issue(s)...

@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Feb 25, 2013

Owner

OK. sounds a bit like the author initials, but applied to the email user name.
Venter på din feedback.

Owner

jonas commented Feb 25, 2013

OK. sounds a bit like the author initials, but applied to the email user name.
Venter på din feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment