Skip to content

Conversation

heli-d-bhavsar
Copy link

I have done refactoring as part of the course assignment. I have analyzed my code using designateJava. My pull request includes the following types of refactoring Refactor using Extract Method, rename Variable, Pull up method, Move method/field, Extract class #1

@joney000
Copy link
Owner

@heli-d-bhavsar appreciated your efforts to clean up some of the very old and messy code snippets.
can we break this into smaller PRs rather than having single commit.
we have so many improvements which you have suggested. let's discuss each one in separate PR and let's merge them one by one.

@joney000
Copy link
Owner

here is what a single PR good to have: -

  1. code change limited to one file\Algorithm only.
  2. Respective changes in readme link (change in file name \ time-space complexity)
  3. if it's an indent change have it in an independent separate commit.

@joney000 joney000 closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants