Skip to content

Conversation

volyx
Copy link

@volyx volyx commented Jul 24, 2016

No description provided.

@jonkemp
Copy link
Owner

jonkemp commented Jul 25, 2016

I have several points here.

  • This warrants a lot more discussion before submitting this pull request. Please refer to the contributing guidelines here.

https://github.com/jonkemp/useref/blob/master/CONTRIBUTING.md#pull-requests

  • I do not see a lot of demand for this feature.
  • Adding it for everyone by default is bad.
  • This pull request breaks tests which is bad.

So I feel like going forward, we need:

  • a consensus, which is difficult since only one person has requested this feature in over a year
  • for it not to be the default, so to opt into it would require a 'strict mode' option or something
  • to not break tests, so new tests will need to be added that would test the option

@jonkemp
Copy link
Owner

jonkemp commented Aug 13, 2016

Closing.

@jonkemp jonkemp closed this Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants