Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 8 support, provide explict encode/decode version. #1

Closed
winterland1989 opened this issue Jul 6, 2016 · 2 comments
Closed

GHC 8 support, provide explict encode/decode version. #1

winterland1989 opened this issue Jul 6, 2016 · 2 comments

Comments

@winterland1989
Copy link

winterland1989 commented Jul 6, 2016

Thanks for making this library! I'd like to ask for a base version bump to support GHC 8, and add explict encode/decode version functions:

putToStream :: OutputStream ByteString -> Maybe Put -> IO () 
getFromStream :: InputStream ByteString -> Get a -> IO (Maybe a) 

Will you accept a PR?

@jonpetterbergman
Copy link
Owner

Hi, yes I will accept a PR regarding this.

I'm traveling ATM but will look at it when I get back home.

/Petter Bergman

2016-07-06 11:50 GMT+02:00 winterland notifications@github.com:

Thanks for making this library! I'd like to ask for a base version bump to
support GHC 8, and add explict encode/decode version functions:

putToStream :: OutputStream ByteString -> Maybe a -> Put a -> IO () getFromStream :: InputStream ByteString -> Get a -> IO (Maybe a)

Will you accept a PR?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1, or mute
the thread
https://github.com/notifications/unsubscribe/AHoFoxwGnjcICwBTsU0ydkH_PQEUfoWEks5qS3pqgaJpZM4JF667
.

@winterland1989
Copy link
Author

Sorry, but later i decide binary/lazy bytestrings combination really not work well with io-streams(or any other streamming libraries), the problem is that a streamming library will stream chunks of strict bytestrings, if we use binary to do encode/decode, we have to go through strict/lazy conversion in and out, so instead i write cereal-streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants