Skip to content

Commit

Permalink
[mono-sdks] <DownloadUri/> should not run during design-time builds (d…
Browse files Browse the repository at this point in the history
…otnet#2439)

Fixes: dotnet#2350

Most of the logic in `mono-runtimes.csproj` was happening during the
`CoreCompile` target.  The problem with this is that design-time
builds in Visual Studio runs `CoreCompile`.  The `Task.Wait()` in the
`<DownloadUri/>` task causes a hang within Visual Studio.

It turns out we could just completely remove the following target:

	<Target Name="CoreCompile"
	    DependsOnTargets="_Build">
	</Target>

`_Build` still runs appropriately. `_BuildUnlessCached` will call
`ForceBuild` or `_Build` depending if things are cached.
  • Loading branch information
jonathanpeppers authored and jonpryor committed Nov 20, 2018
1 parent 7387909 commit 9ae7454
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/mono-runtimes/mono-runtimes.targets
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,4 @@
<Delete Files="@(_StampFiles)" />
</Target>

<Target Name="CoreCompile"
DependsOnTargets="_Build">
</Target>
</Project>

0 comments on commit 9ae7454

Please sign in to comment.