Separate stopMocking() into disableMocking() and stopMocking() #140

cerihughes · 2017-01-04T14:45:24Z

A PR to address the crash that happens when a mock is called from a dealloc method (and ONLY the dealloc method).

See #141 for context.

coveralls · 2017-01-04T14:59:41Z

Coverage decreased (-0.07%) to 98.653% when pulling 19f76cc on cerihughes:cerihughes/disable-mocks into 36857f0 on jonreid:master.

coveralls · 2017-01-04T15:30:31Z

Coverage increased (+0.006%) to 98.728% when pulling 902f967 on cerihughes:cerihughes/disable-mocks into 36857f0 on jonreid:master.

coveralls · 2017-01-07T14:07:06Z

Coverage increased (+0.006%) to 98.728% when pulling ff68fa1 on cerihughes:cerihughes/disable-mocks into 36857f0 on jonreid:master.

coveralls · 2017-01-07T14:54:54Z

Coverage increased (+0.006%) to 98.728% when pulling ae294b8 on cerihughes:cerihughes/disable-mocks into 36857f0 on jonreid:master.

jonreid · 2017-01-08T17:43:17Z

Thank you for your continued attention to this subtle problem! I appreciate your thorough explanations, and failing test cases SO MUCH.

cerihughes added 2 commits January 4, 2017 15:13

Add a failing test

50b634b

Separate disabling from stopping of mocks

19f76cc

cerihughes mentioned this pull request Jan 4, 2017

Crash when calling mocks from dealloc that are not called from elsewhere #141

Open

Add tests for bad input

902f967

It’s 2017!

ff68fa1

Follow test naming convention

ae294b8

jonreid merged commit 9f25e13 into jonreid:master Jan 8, 2017

jonreid added a commit that referenced this pull request Feb 19, 2017

Revert pull request #140 which had added disableMocking

9ab81c0

Provide feedback