Skip to content

Module cache deprecation #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Module cache deprecation #103

wants to merge 6 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 4, 2023

No description provided.

@HLeithner
Copy link
Member

Hi Allon,

you did make 2 mistakes.

  1. as already said, please don't make changes to the migration/44-50 directory in the main branch
  2. in this case the deprecation is added to Joomla 4.4 and needs to to be added to the migration/43-44 entry

@laoneo
Copy link
Member Author

laoneo commented Apr 4, 2023

To which branch then?

@HLeithner
Copy link
Member

To which branch then?

for this pr it's the wrong directory but the correct branch.

for 5.0 changes its the 5.0 branch

@laoneo
Copy link
Member Author

laoneo commented Apr 4, 2023

Moved the to the 4.3 file

@HLeithner
Copy link
Member

thanks.

Is the wording of the files too complicated or confusing?

@laoneo
Copy link
Member Author

laoneo commented Apr 4, 2023

Personally I would expect a file with the name 4.4 which contains all deprecation which are done in 4.4. Where and how this file is then displayed is another story. It is all about the perspective, now it is the perspective for the end developer who reads it, I have the perspective of the developer who does it. But you can leave it as it is, no problem.

@laoneo laoneo changed the title Update new-deprecations.md for https://github.com/joomla/joomla-cms/pull/40316 Module cache deprecation Jun 26, 2023
@laoneo laoneo closed this Jun 26, 2023
@laoneo laoneo deleted the laoneo-patch-1 branch June 26, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants