This repository has been archived by the owner on Jan 25, 2021. It is now read-only.
Add Metismenu to Cassiopeia, rework Cassiopeia's HTML structure, use relative CSS sizes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an alternative layout for mod_menu including (loading) metismenu, added a new scss file for styling the menu
Metismenu frontend
…omla-cms into metismenu-frontend
Metismenu frontend - wrapping UL attributes in an array
…omla-cms into metismenu-frontend
Metismenu frontend
🗑️ removal obsolete reference to deleted file
The menu class suffix is a menu class on J4, not a suffix.
- added an "if parent" in heading and separator to add arrow class - reverted $class[] because it was not working - minor style changes
…dev-frontend-html-structure # Conflicts: # templates/cassiopeia/scss/template.scss # templates/cassiopeia/scss/tools/_tools.scss # templates/cassiopeia/scss/vendor/choicesjs/choices.scss
…peia/4.0-dev-frontend
…4.0-dev-frontend # Conflicts: # templates/cassiopeia/scss/blocks/_header.scss
richard67
changed the title
This was referenced Aug 28, 2020
richard67
changed the title
This was referenced Aug 28, 2020
… and clean up sub-layouts (#45) * Separate link and button for dropdown items - Move dropdown handling to main layout override - Remove obsolete sub-layout overrides * Use language string for screenreader text * Add missing language string for frontend * Adapt metismenu scss to changed dropdown
…-and-html-structure
richard67
approved these changes
Aug 30, 2020
|
Am merging into the development branch for now. For further improvements please make pull requests against the development branch. |
richard67
deleted the
cassiopeia/4-0-dev-frontend-metismenu-and-html-structure
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues #33 and #9 .
Summary of Changes
Structure
Remove banner from header
Change position of nav and search
Several css changes to adapt to the new design
Menu
This pull resuest (PR) adds a new layout for an accessible frontend menu with dropdowns using metismenujs to the Cassiopeia template of Joomla 4.
Metismenujs is a vanilla js variant of metismenu, i.e. it doesn't depend on jquery.
It is acessible and responsive and provides pull-downs.
We use it already in the backend in the Atum template, so using it in Cassiopeia, too, doesn't cause a new external dependency.
Testing Instructions
Apply the changes in this PR to a clean, current 4.0-dev branch and then run npm ci.
Expected result
Actual result
Documentation Changes Required