Skip to content

Conversation

roland-d
Copy link
Contributor

@roland-d roland-d commented Oct 1, 2018

As per the discussion in the CMS Maintainers chat, here is a first draft of the codestyle for our language files.

It would be good to have separate section here for INI files but I don't see how I can do that:
image

Pinging @infograf768 as the text is his :)

@infograf768
Copy link
Member

We can also add Netbeans plugin:
http://plugins.netbeans.org/plugin/45925/sort-line-tools

@mbabker
Copy link
Contributor

mbabker commented Oct 1, 2018

It would be good to have separate section here for INI files but I don't see how I can do that:

The documents have to be added in the component backend. Nothing you can do through GitHub.

@wilsonge
Copy link
Contributor

wilsonge commented Oct 1, 2018

Can we add a note referring to the English style guide please and document that language strings are in en-GB as we're doing this please

@infograf768
Copy link
Member

@roland-d
Can you do what George asks?

@roland-d
Copy link
Contributor Author

@wilsonge Done, can you check if it is OK like this?

@wilsonge wilsonge merged commit c2bed76 into joomla:master Oct 23, 2018
@wilsonge
Copy link
Contributor

Sorry just got back from holiday. Looks good to me. Thanks

@infograf768
Copy link
Member

Thanks for merging
Now needs to be ported to
https://developer.joomla.org/coding-standards/basic-guidelines.html
for manual/basic-guidelines.md
and to a specific section in https://developer.joomla.org/coding-standards/introduction.html
for manual/ini.md

@mbabker
Copy link
Contributor

mbabker commented Oct 23, 2018

The pages read from this repo as the site's cache expires, so all content work can happen in this repo and it should sync within the hour.

On the site itself, the only work required is adding the new page to the menu system (because we do still have to tell the component what files from a repo are available as pages, otherwise in the case of this repo we end up in allowing the PHP files to be web pages and we don't want that). And that is done, https://developer.joomla.org/coding-standards/ini.html

@roland-d
Copy link
Contributor Author

Thanks @mbabker

@roland-d roland-d deleted the feature/ini-guidelines branch October 23, 2018 17:23
@infograf768
Copy link
Member

👍

@rvbgnu
Copy link

rvbgnu commented Oct 24, 2018

Thanks @roland-d @wilsonge @mbabker @infograf768 ! Good things to have it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants