New Feature: Schedule featured articles #13596 #16960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move JControllerLegacy to namespace * Change content controller to use the new Base controller class * Adapting the test as JControllerLegacy has a different class name * New line at the end of the file * Activating tests * Reset to the original state * Rename Base to Controller * Change name to new class name Controller * Move to Cms namespace * Load the Cms namespace trough composer * Fix the test again * Composer dump with latest version * Move to Joomla only namespace in composer.json * Move JControllerAdmin to namespace * Happy travis * Add missing alias
* Move JViewLegacy to namespace * Add alias for JViewLegacy on JLoader * Move the categories views to namespace
* Move JModelLegacy to namespace * Move JModelList to namespace * Move JModelAdmin to namespace * Move JModelForm to namespace * Also use the proper namespace for exceptions * Update the class alias list * Namespace stdClass * Fixe some simple tests * Auch * Extend from new model class * Remove tests which rely on the hash cache * CS fixes
* Fix namespace for exceptions * Move JTable to namespace * Move JTableObserver to namespace * Move JTableInterface to namespace * Move JTableNested to namespace * Move JTableObserverContenthistory to namespace * Move JTableObserverTags to namespace * Fix code style and unit test * Remove package information in docblock * Package is not required anymore in docblock * Revert invalid composer commit * Move JTableAsset to namespace * Move JTableExtension to namespace * Move JTableLanguage to namespace * Move JTableUpdate to namespace * Move JTableUpdatesite to namespace * Move JTableUser to namespace * Move JTableUsergroup to namespace * Move JTableViewlevel to namespace * Update doc block, remove package declaration * Fix intendion cs error
* Move JAccess to namespace * Fix some minor stuff and delete JRule and JRules
* Add override plugin * Support overrides of namespaced classes * Better function name * Move override plugin to rep * Revert to none namespaced version as on staging * Load the Joomla namespace trough JLoader * JLoader alis load class support * CS * Only load the alias when the original class exists * One more space, outch * Add unit tests * Add note about use of composer
* Move JCaptcha to namespace * Change CMS classes as well * Adapted intendation
* Move JErrorPage to namespace * Doc block comment should be inline with the rest * Move class to Joomla\Cms\Exception\ExceptionHandler * Correct class name
* Change JComponent* classes to namespace * Adapted intendation * Check for new interface * Intendation
It was a bit ambiguous so I updated the string to be more explicit ### Before ### After
Update the deprecated notice on an unused file to indicate that it will be removed in J4
…em/debug (#16674) * Some improvements and cleanups in plugins/system/debug - Make use of $this->db instead of JFactory::getDbo()(); - Added missing docblocks - Type-safety - replace unnecessary strlen() call with simple check - CS * A few more changes * A few more changes * Changes based on reviewer's comment * cs * cs * cs * cs * cs
On new installs this changes the vote plugin to be disabled by default. It is not used that often and by disabling it we also benefit from a simpler article list view in the admin
The text used for the banned fields in com_contacts is different in the commponent options and the individual contact options. Irrelevant of if the information is needed or not we should be consistent. So on the basis that it is important to have the extra information I have updated the individual contact strings to match the global ones.
* Push up the destructor from various database drivers to their parent abstract class JDatabaseDriver as it almost every time just does one thing viz disconnect(). Otherwise it can always be overridden. Never `unset` class property. $this->connection set to null in disconnect methods. Nosql connect return is void not bool. * Use version macro now
* put multiple versions of the same <meta> tag * fixed code-style errors * remove tabs * cs: Remove tabs
* Case mismatch in function call * Elvis * Fix nested positive ifs * Fix static method invocation via -> * " to ' * Remove unnecessary parentheses * Merged isset() * Inline redundant value * Move disconnected code outside the foreach loop. * Fixed Docblocks * Replaced preg_replace() with str_replace() * Replaced PHP4 type-casting * Type-safe string comparisons * More type-safe comparisons * Removed unused call and variable. Also Todo'd two things for someone to check * Reverse preg_replace() replacement because there was a limit in preg and it might cause trouble... * Codesniffer * Fix integer * Changes proposed by @andrepereiradasilva and two more by me, to get function calls out of the loop or reduce calls inside the loop. * Shouldn't this be written this way? * Some extra work according to @andrepereiradasilva's notes * Some more changes from @andrepereiradasilva's comments * Some more changes from @andrepereiradasilva's comments * Reverted removal of duplicate key entries, added TODO's * Code formatting fixes * More code formatting fixes * Fix merge introduced problem. * Additional changes according to reviewer's comments * Additional changes according to reviewer's comments * Changes, according to @andrepereiradasilva's suggestions * Forgot to commit this one
* Add CSRF token for Ajax * Add CSRF token to hathor * CS * call jquery first * Use server->get() * Loaded once * Add CSRF to core.js request method * Use CSRF instead Csrf * Use scriptOption * Fix test * MISC update * Use $name variable in JS * Use string as script option directly and fix tests
|
Can you look at resolving the conflicts so that this can be tested please. |
…ule-featured-articles-#13596
joomla-cms-bot
removed
Language Change
|
@eshiol it looks like you have many not needed files included here? |
|
I merged the remote-tracking branch 'refs/remotes/joomla/3.8-dev', my mistake. But now, I'm not able to revert it. |
|
@eshiol if |
|
Just do a git reset --hard upstream/staging if you want to make the branch
the same as the staging branch
…--
Tony Partridge
From: Walt Sorensen <notifications@github.com> <notifications@github.com>
Reply: joomla/joomla-cms
<reply@reply.github.com>
<reply@reply.github.com>
Date: 22 August 2017 at 04:31:36
To: joomla/joomla-cms <joomla-cms@noreply.github.com>
<joomla-cms@noreply.github.com>
CC: Tony Partridge <admin@xtech.im> <admin@xtech.im>, Mention
<mention@noreply.github.com> <mention@noreply.github.com>
Subject: Re: [joomla/joomla-cms] New Feature: Schedule featured articles
#13596 (#16960)
@eshiol <https://github.com/eshiol> if git revert 956a9cd won't allow you
to revert you will likely have to figure out how to redo the source work.
(there is probably some way to create a new branch and cherry pick commit
09f5cd5
<09f5cd5>
then overwrite the broken branch in this PR, but I'm not up on all of the
pr "rescue" techniques for fixing mistakes and broken branches.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16960 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVgloes6B-Mu9YvlwJDT9WeXs0136zzks5sakuXgaJpZM4ONEhM>
.
|
|
Broken PR. I'll open a new one. Sorry. |
|
I just installed 3.8.0 and this feature is not yet available in the backend. |
|
@mijalis As stated above this was closed by the submitter and is awaiting a new pull request |
This was referenced Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #13596.
Summary of Changes
Added two fields in the article editor
featured_up(Start Featured) andfeatured_down(End Featured)An article is featured if
featuredis yes and (featured_upis null or is less than or is equal to now) and (featured_downis null or is greater than or is equal to now)Testing Instructions
create 5 articles:
Create an
Articles » Featured Articlesmenu itemCreate a
News Flashmodule and set the optionFeatured ArticlestoOnly show Featured Articles.Expected result
Only the articles 2 and 5 will be shown in the
Articles » Featured Articlesmenu item and in theNews Flashmodule.Actual result
Documentation Changes Required