Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [WIP] Links to buttons #23737

Closed
12 of 15 tasks
zwiastunsw opened this issue Feb 1, 2019 · 7 comments
Closed
12 of 15 tasks

[4.0] [WIP] Links to buttons #23737

zwiastunsw opened this issue Feb 1, 2019 · 7 comments

Comments

@zwiastunsw
Copy link
Contributor

zwiastunsw commented Feb 1, 2019

In alpha6 version I found 15 files in which instead of the tag button was used the a tag with the attribute role=button. We have already explained that this is an accessibility error that needs to be fixed.
Could anyone improve these files?
It has already happened that @SharkyKZ corrected a number of errors of this type in one PR (#22494)
Below is a list of them.

  • administrator/components/com_asotiations/Field/Modal/AsotiationsField.php
  • administrator/components/com_categoies/Field/Modal/CategoryField.php
  • administrator/components/com_contact/Field/Modal/ContactField.php
  • administrator/components/com_content/Field/Modal/ArticleField.php
  • administrator/components/com_content/View/Article/HtmlView.php
  • administrator/components/com_fields/Field/Modal/FieldField.php
  • administrator/components/com_media/resources/scripts/components/modals/share-modal.vue
  • administrator/components/com_menus/tmpl/item/edit_modules.php
  • administrator/components/com_menus/tmpl/menus/default.php
  • administrator/components/com_newsfeeds/Field/Modal/NewsfeedField.php
  • administrator/components/com_templates/Service/HTML/Templates.php
  • administrator/modules/mod_logged/tmpl/default.php
  • administrator/modules/mod_multilangstatus/tmpl/default.php
  • installation/tmpl/remove/default.php
  • layouts/joomla/toolbar/versions.php
    I did not check, but I suppose similar changes are needed in Joomla3.
@brianteeman
Copy link
Contributor

i strongly suspect that these have all been fixed in 3.9 by @SharkyKZ and are just waiting for @wilsonge to merge them into j4. j4 is currently over 1000 commits behind/

@brianteeman
Copy link
Contributor

i can see that these are still present BUT most are for modal close buttons which is scheduled to be rewritten. I will do a pr for the rest

wilsonge added a commit that referenced this issue Apr 17, 2019
Removes a redundant role attribute. These are links and are not acting like buttons
wilsonge added a commit that referenced this issue Apr 17, 2019
Removes a redundant role attribute. These are links and are not acting like buttons
@ghost ghost changed the title [4.0][a11y] Links to buttons [4.0] [WIP] Links to buttons Apr 19, 2019
@Quy
Copy link
Contributor

Quy commented May 13, 2019

Please confirm that this can be closed.

@wilsonge
Copy link
Contributor

Looks like 3 files left to me

@Quy
Copy link
Contributor

Quy commented Jun 8, 2019

Related PR #23740

@Quy
Copy link
Contributor

Quy commented Jun 8, 2019

Deleted in PR #25139.
administrator/components/com_fields/Field/Modal/FieldField.php

Fixed in PR #25126
administrator/components/com_menus/tmpl/menus/default.php
administrator/modules/mod_multilangstatus/tmpl/default.php

@joomla-cms-bot joomla-cms-bot removed the a11y Accessibility label Jun 8, 2019
@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants