-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [WIP] Links to buttons #23737
Labels
Comments
i can see that these are still present BUT most are for modal close buttons which is scheduled to be rewritten. I will do a pr for the rest |
wilsonge
added a commit
that referenced
this issue
Apr 17, 2019
Removes a redundant role attribute. These are links and are not acting like buttons
wilsonge
added a commit
that referenced
this issue
Apr 17, 2019
ghost
changed the title
[4.0][a11y] Links to buttons
[4.0] [WIP] Links to buttons
Apr 19, 2019
Please confirm that this can be closed. |
Looks like 3 files left to me |
This was referenced Jun 5, 2019
Merged
Related PR #23740 |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In alpha6 version I found 15 files in which instead of the tag
button
was used thea
tag with the attributerole=button
. We have already explained that this is an accessibility error that needs to be fixed.Could anyone improve these files?
It has already happened that @SharkyKZ corrected a number of errors of this type in one PR (#22494)
Below is a list of them.
I did not check, but I suppose similar changes are needed in Joomla3.
The text was updated successfully, but these errors were encountered: