Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync branch staging #24720

Closed
wants to merge 34 commits into from
Closed

Sync branch staging #24720

wants to merge 34 commits into from

Conversation

ReLater
Copy link
Contributor

@ReLater ReLater commented Apr 24, 2019

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

ReLater and others added 30 commits August 4, 2018 04:00
…red (#21321)

* [New Feature] Multilingual: Propagating existing associations if desired

* cs

* lang change

* Change and add new messages

* lang changes

* Small corrections without effect on resulting funtionnality

* using new API for token

* modifying js function to use Joomla. instead of window.
* Escaping float value should be non-locale aware

* Fix sqlite query dateAdd and add unit tests
* Don't need a closure, jQuery ready function is enough. Use strict.

* Radio buttons and tooltips work in subforms.

* Make chose colors work in dynamically added Chosen (in new subform rows, for example)

* Combine the two init functions as one. No reason to call two functions here.
* Repair the update of database schema changes on postgreSQL

* Add a better regex to split actions by comma

* Remove useless code

* Add a comment to sql file
* [com_content] Tags not shown in some cases

* Featured view

* CS
* Cleanup batch copy of items

* Fix codestyle

* Banners doesn't use a title field

* Fix merge conflict

* Fix batch copy not copying fields
* Use the fixed menu item for open search url

* Fix Itemid
* Allow filtering by archived state in redirect component

* Fix spaces
* Merge some unset()

* Lots of work on the indexer itself:

- Type safe comparisons
- a few simplifications
- a few performance optimizations

* Some Elvis's and a missing @SInCE annotation

* One more StringHelper...

* Codestyle...

* Not to potentially break BC, reversed back to `!empty($var)` operation but with the non inverted style `(bool) $var`

* Formatting

* Fix formatting

* Revert this change for now. Look into it later again.

* Codesniffer...

* Removed repeated `use`

* Some extra work according to @andrepereiradasilva's notes

* Additional changes according to reviewer's comments

* Code style

* Fix misbehavior due to not correctly handling the single object case of mixed variable (array|object)

* Pass float value to db->escape as float may produce problems for some locales.

* "Make values float again" - (pun intended)
* Tab not slider

As probably the majority of people use isis and not hathor templates AND we have almost told people not to use hathor any more then we should use the correct language when describing a tab. It was only a "slider" inn joomla 2.5 and hathor but its clearly a tab in isis

* grammar
@ReLater
Copy link
Contributor Author

ReLater commented Apr 24, 2019

Sorry!

@ReLater ReLater closed this Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet