A fix for count() misuse / Catchable fatal error (ref #14873) #14982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line 382 assigns $this->_children = false, but count(boolean) is always 1, that causes the sorting block to execute and fail with fatal error.
if ($this->_children) would fix this bug,
if (count($this->_children) > 1) fixes the bug and skips sorting of one-member arrays
Pull Request for Issue #14873.