-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Groups - removed label: enabled/disabled users v2 #17924
Conversation
I have tested this item ✅ successfully on ee17910 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924. |
It should be done like the Categories page where the text is wrapped in a
|
@pe7er any Opinion on @Quy's Comment above? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924. |
@Quy Sorry, I do not understand your remark. |
@pe7er the problem is that by doing that you left the code in a non accessible state. The change suggested by @Quy will resolve that. For reference see http://fontawesome.io/accessibility/ |
@brianteeman @Quy I don't understand what needs to be changed. |
Tried to create a pull on your branch but it wouldnt let me ;( This is the code
|
I have tested this item ✅ successfully on ee17910 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924. |
Ready to Commit after two successful tests. |
Please remove the RTC it needs to be updated with the code I suggested |
Status set back on "Pending" as stated above. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924. |
@pe7er will you be updating this or shall we close it |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17924 |
Closing in favor for #20279. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924. |
New PR to replace #12086 "User Groups - removed label: enabled/disabled users"
See #12086 for description.
In this new PR I just removed the "enabled users" and "disabled users" label, and only kept the icon.
Should work on mobile too now.