Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Groups - removed label: enabled/disabled users v2 #17924

Closed
wants to merge 1 commit into from
Closed

User Groups - removed label: enabled/disabled users v2 #17924

wants to merge 1 commit into from

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented Sep 10, 2017

New PR to replace #12086 "User Groups - removed label: enabled/disabled users"
See #12086 for description.

In this new PR I just removed the "enabled users" and "disabled users" label, and only kept the icon.
Should work on mobile too now.

@ghost
Copy link

ghost commented Sep 10, 2017

I have tested this item ✅ successfully on ee17910


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

@Quy
Copy link
Contributor

Quy commented Sep 16, 2017

It should be done like the Categories page where the text is wrapped in a <span class="element-invisible"> for accessiblity.

<span class="icon-publish hasTooltip" aria-hidden="true" title="Published items"><span class="element-invisible">Published items</span></span>

@ghost
Copy link

ghost commented Oct 26, 2017

@pe7er any Opinion on @Quy's Comment above?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

@pe7er
Copy link
Contributor Author

pe7er commented Oct 26, 2017

@Quy Sorry, I do not understand your remark.
I just removed 2 labels with span tags around them.

@brianteeman
Copy link
Contributor

@pe7er the problem is that by doing that you left the code in a non accessible state. The change suggested by @Quy will resolve that. For reference see http://fontawesome.io/accessibility/

@pe7er
Copy link
Contributor Author

pe7er commented Oct 26, 2017

@brianteeman @Quy I don't understand what needs to be changed.
Could you please provide a patch. Thanks!

@brianteeman
Copy link
Contributor

Tried to create a pull on your branch but it wouldnt let me ;( This is the code


						<th width="1%" class="nowrap center">
							<span class="icon-publish hasTooltip" aria-hidden="true" title="<?php echo JText::_('COM_USERS_COUNT_ENABLED_USERS'); ?>">
								<span class="element-invisible"><?php echo JText::_('COM_USERS_COUNT_ENABLED_USERS'); ?></span>
							</span>
						</th>
						<th width="1%" class="nowrap center">
							<span class="icon-unpublish hasTooltip" aria-hidden="true" title="<?php echo JText::_('COM_USERS_COUNT_DISABLED_USERS'); ?>">
								<span class="element-invisible"><?php echo JText::_('COM_USERS_COUNT_DISABLED_USERS'); ?></span>
							</span>
						</th>

@ladyjer
Copy link
Contributor

ladyjer commented Nov 18, 2017

I have tested this item ✅ successfully on ee17910

Hi, tested successfully.
I agree with Brian, element is needed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

@ghost
Copy link

ghost commented Nov 18, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 18, 2017
@brianteeman
Copy link
Contributor

Please remove the RTC it needs to be updated with the code I suggested

@ghost
Copy link

ghost commented Nov 18, 2017

Status set back on "Pending" as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 18, 2017
@brianteeman
Copy link
Contributor

@pe7er will you be updating this or shall we close it

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17924

@Quy
Copy link
Contributor

Quy commented May 2, 2018

Closing in favor for #20279.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

@pe7er pe7er deleted the user-groups-enabled-disabled-users-v2 branch September 25, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants