[4.0] [a11y] Rules permissions - text filters notes #21559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure what the logic/reasoning was for putting the notes on the permissions tab inside a custom element "joomla-alert" but it was wrong - it is not an alert it is just information. Making it an alert has significant impact. This custom element adds role="alert" to the container. In a11y this role=alert is equivalent to using aria-live=assertive. aria-live="assertive" should be used only when you think the user needs to know the information the very second it appears. So what happens is that as soon as the permissions tab gets focus and before anything else can happen the entire content of the alert is announced (and cannot be interrupted because it is so important). This PR changes it back to a simple div and adds css to match the current styling - which obviouslly can be changed and improved upon.
houndci-bot
reviewed
Aug 11, 2018
| @@ -12,4 +12,9 @@ | |||
| margin-bottom: 2rem; | |||
| } | |||
| } | |||
|
|
|||
| .rule-notes { | |||
| background-color: $white; | |||
There was a problem hiding this comment.
Properties should be ordered padding, background-color
brianteeman
changed the title
# Conflicts: # administrator/templates/atum/css/template-rtl.css # administrator/templates/atum/css/template-rtl.min.css # administrator/templates/atum/css/template.css # administrator/templates/atum/css/template.min.css
|
Conflicts resolved |
|
I have tested this item ✅ successfully on e6ff344 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559. |
1 similar comment
|
I have tested this item ✅ successfully on e6ff344 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559. |
|
Thanks |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure what the logic/reasoning was for putting the notes on the permissions tab inside a custom element "joomla-alert" but it was wrong - it is not an alert it is just information. Making it an alert has significant impact.
This custom element adds role="alert" to the container. In a11y this role=alert is equivalent to using aria-live=assertive. aria-live="assertive" should be used only when you think the user needs to know the information the very second it appears.
So what happens is that as soon as the permissions tab gets focus and before anything else can happen the entire content of the alert is announced (and cannot be interrupted because it is so important).
This PR changes it back to a simple div and adds some simple css - which obviously can be changed and improved upon.
[update]
Also added the text-filter notes at the bottom of the page to this PR as its basically the exact same problem
(can be tested with patchtester)