[4.0] Improve a11y for systeminformation #21724
Conversation
| th { | ||
| font-weight: bold; | ||
| } | ||
|
|
| // com-admin | ||
|
|
||
| .sysinfo { | ||
| .table { |
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
chmst
changed the title
ghost
mentioned this pull request
|
#21628 is closed as requested. |
|
Looks good - can you fix hound please |
|
Additionally we have a merge conflict in this files: |
| font-weight: bold; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Files should end with a trailing newline
|
@wojsmol can you help me? I don't know how to resolve conflicts in .min.css files. |
|
@chmst I send PR reverting my last changes. |
|
All right. I don't understand the conflicts, because the .css and min.css files should be generated from the scss files. |
…ation-2 Revert "resolve comflicts"
|
accept my last PR then I prepare good one. |
|
It is merged. Is there something else I have to do? |
| $focus-highlight-color: #39f; | ||
| $focus-highlight-color: #39f; | ||
|
|
||
| // Breadcrumbs |
|
@wojsmol hope that the conflict is resolved now. Thank you for your patience |
|
I have tested this item ✅ successfully on cd203ad This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724. |
|
@chmst Please remove |
|
@brianteeman all ok here from your side? |
|
@laoneo it was good when I first checked it - not sure if there have been significant changes since |
|
Do you mind to have another look? |
|
Wait a moment. There is another PR which has changed something in the library. I can resolve this as soon as the other change is merged. |
|
@laoneo I will put it on my todo for tonight |
|
I have tested this item ✅ successfully on cf368e5 I have also tested with Wave Automatic Test and I got the error of an empty th which belongs to the php info about mysqlnd statistics which was empty in my server but I do not think it's related with this PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724. |
|
@carcam thank you for testing. And good finding of the empty in the php-info. Let's make another PR for the sysinfo model, to avoid empty table headers. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724. |
|
I tested this patch. Fieldset and legend elements have been rightly removed. But... |
|
I'm going to merge this as a good piece of progress even though it would appear there's some more to do here from the comments by @zwiastunsw |
|
@wilsonge thank you! So I can continue without raising conflicts ;) |
JAT has found several a11y issues in the SystemInformation View:
This PR replaces #21628 which I have deleted - my mistake. Could someone please close the old PR? Sorry for inconvenience.
Summary of Changes
Remove the < form > tag, as this is not a form.
Remove empty Table Footers
Replace the < fieldset > Tag by < div >
Remove the < legend > by Table < caption >
Improve the Table header with some css, add a new scss file for com_admin