Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][a11y] Incorrectly named ARIA attribute #23834

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Feb 8, 2019

Problem diagnosed by the JAT team.
All switches have a non-existent name aria attribute: aria-labeledby. Should be: aria-labelledby (two letters "l")

If the developer uses a non-existent or misspelled ARIA attribute, the attribute will not be able to perform the accessibility function intended by the developer.

Summary of Changes

Invalid attribute replaced with correct attribute

Testing Instructions

Code review

Note

This may be the reason that labels are not announced by the screen reader.

@brianteeman
Copy link
Contributor

Good spot

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on e10edb9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23834.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Feb 9, 2019

I have tested this item ✅ successfully on e10edb9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23834.

@Quy
Copy link
Contributor

Quy commented Feb 9, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23834.

@wilsonge wilsonge merged commit 23d5fb7 into joomla:4.0-dev Feb 14, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 14, 2019
@wojsmol wojsmol deleted the j40-a11n-fix-js-typo branch February 14, 2019 12:32
@wojsmol wojsmol changed the title [4.0][a11n] Incorrectly named ARIA attribute [4.0][a11y] Incorrectly named ARIA attribute Feb 20, 2019
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants