-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0]Breadcrumbs are now more accessible #24113
[4.0]Breadcrumbs are now more accessible #24113
Conversation
@hardik-codes Please provide testing instructions and image if possible. |
@Anu1601CS apply patch. check generated code of breadcrumbs module. |
I have tested this item ✅ successfully on 34d63f3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24113. |
@brianteeman We know how to test. Instructions only for new students who want to test :) |
@zwiastunsw if you prefer the aria-current="page", @hardik-codes can change it. |
Comment by LÉONIE WATSONJANUARY 26TH 2017, 8:44AM
|
I know the opinion of L. Watson and I fully agree with her. The value "true" is also correct here, although it is better to use a "page" or "location". |
@Anu1601CS I've updated the testing instructions as per @brianteeman guidelines |
@zwiastunsw as I have commented before, the last link in a breadcrumb never is a link but a text. Always. you wrote
So now we need a decision: Do we use the attribute in joomla or not? |
Here is an example of how a screen reader announces a breadcrumb when the last item is a link:
If the last item is not a link, the screen reader skips it during tabulation. The cursor moves to the next item on the page. The user hears only:
Note: The screen reader announces that there are 4 items, but communicates only three items. That is why I believe that this should be a link. But this does not mean that it is just the right solution. It is a question of preference. I do not know of studies that would show which solution blind people prefer. If I had to decide, the last element would be made by a link. |
Having a link to the same page makes no sense Unlikely that the next link would be announced as being part of the breadcrumb list because the links should be enclosed in a different region |
You have the right to think this way. But that's just your opinion. In the navigation menu we have links to the current page. We even have special CSS classes for them - current, active. Doesn't it also make sense? I would like to emphasise once again: I do not think that my opinion is merely the right one. We have different patterns on the web. The W3C in the WAI-ARIA Practices document presents a breadcrumb design pattern in which the last element is a link. Doesn't make sense?
|
Still regarding the value of the
The screen reader announces accordingly: "current" || "current page" || "location". Definitely, it is best to use the value |
I have tested this item ✅ successfully on 34d63f3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24113. |
Status "Ready To Commit". |
Changed to the value of |
thanks @wilsonge |
Summary of Changes
Added
aria-current
tomodules/mod_breadcrumbs/tmpl/default.php
Testing Instructions
Apply the patch and check the generated code of breadcrumbs module
Documentation Changes Required
None