Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove remaining PSR-0 code in JLoader #31188

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Oct 21, 2020

Pull Request for Issue #31159.

Summary of Changes

Removes the unused PSR-0 code in JLoader.

Testing Instructions

Open Joomla.

Actual result BEFORE applying this Pull Request

All works as expected.

Expected result AFTER applying this Pull Request

All works as expected.

Documentation Changes Required

Needs a note, that loadByPsr4 is deprecated.

@adj9
Copy link

adj9 commented Oct 21, 2020

I have tested this item ✅ successfully on 7ac17ea

Variation global conf: enable debug

Steps-

  • Apply PR
  • Log-out
  • Login

I dont have error of use CMS.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31188.

@jwaisner
Copy link
Member

@laoneo looks like some errors from drone around the JS. Can you please correct?

/********/src/administrator/components/com_media/resources/scripts/app/Api.es6.js
1:1 error Parsing error: The keyword 'import' is reserved

@Fedik
Copy link
Member

Fedik commented Oct 23, 2020

@jwaisner that JS errors not related to changes in current pull request

@infograf768
Copy link
Member

restarted drone

@bonzani
Copy link

bonzani commented Oct 24, 2020

I have tested this item ✅ successfully on 7ac17ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31188.

@Quy
Copy link
Contributor

Quy commented Oct 24, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31188.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 24, 2020
@infograf768 infograf768 merged commit 684a137 into joomla:4.0-dev Nov 11, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 11, 2020
@infograf768
Copy link
Member

Tks

@infograf768 infograf768 added this to the Joomla 4.0 milestone Nov 11, 2020
@laoneo laoneo deleted the j4/cleanup/psr0 branch January 10, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants