Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Multiple Media Manager Fixes #39266

Draft
wants to merge 6 commits into
base: 4.4-dev
Choose a base branch
from

Conversation

crystalenka
Copy link
Member

Closes issues #39126, #39078, possibly others.

Summary of Changes

What started as something straightforward ended up fixing a few things... it's a couple small fixes so it made more sense to group them.

  1. Media sources are now in a (open by default) details element.
    • This doesn't make much difference when someone only uses the default images folder, but if you have multiple image sources defined, this will make it much easier to navigate.
  2. Folders now get hover and focus styles.
    • They didn't before. Now they do.
  3. Super long folder names are now safely contained instead of stretching the container forever.
    • Previously, long file names would stretch the sidebar instead of wrapping or being truncated. This makes file names truncated as they were originally intended to (from what I can tell of the original CSS).
  4. Media sources scroll independently of the images list (Media Manager folder tree #39126) and no longer stack behind one another if more than one is defined.
  5. Infobar stays with you when you scroll. You no longer have to chase it to the top of the page. (Media Manager Info Bar #39078)

Testing Instructions

  1. Go to the media manager and define a bunch of new random folders (enough so the list is taller than your browser height).
  2. Scroll up and down.
  3. Select the last item on the list and try to access the info box.

Actual result BEFORE applying this Pull Request

  • Long folder names stretched out the file tree container

PNG image

  • You could not get to the last items on the file tree until you reached the end of the image list (see video in Media Manager folder tree #39126)
  • The info box was always at the top of the page, even if you were trying to get an item all the way at the bottom of it. (See screenshot in Media Manager Info Bar #39078 )

Expected result AFTER applying this Pull Request

A much nicer experience.

  • Media sources can be entirely collapsed.
  • Long folder names are truncated with ellipses.
  • You can scroll the file tree independently of the image list.
  • The info box stays with you as you scroll.

Known issues

The list view. It's a mess, both before and after this PR. I will address it in another PR at a separate time because there are a lot of things that need to be improved.

That being said, it shouldn't be worse after this PR, so please let me know if there are new issues in the list view that do not exist before applying this PR.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

In cases when multiple media sources are defined, it's hard to navigate any but the first media source. By making each media source a disclosure element, a user can now easily jump between media sources without scrolling for forever.
Folders did not get any kind of styles on hover before. Now they do.
Previously, long file names would stretch the sidebar instead of wrapping or being truncated. This makes file names truncated as they were originally intended to (from what I can tell of the original CSS).
Before there was no max height, so the folder list would not scroll until you reached the bottom of the image list (which can be quite a while).

Now each media source has a reasonable max height and scrolls independently.

Plus, if there are multiple media sources, they no longer stack on top of each other as you scroll.
No longer gets stuck at the top of the content.
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Nov 20, 2022
@crystalenka crystalenka marked this pull request as ready for review November 20, 2022 20:44
@crystalenka crystalenka marked this pull request as draft November 20, 2022 20:47
@crystalenka
Copy link
Member Author

Funky flex bugs happening when you switch folders or show/hide the main joomla sidebar menu. Marking this as draft until I can address. Sigh.

If anyone wants to give those particular issues a try then they're welcome to.

@brianteeman
Copy link
Contributor

There is also #39222

@crystalenka
Copy link
Member Author

There is also #39222

I just saw that but I don't think there is a conflict, it's still a good change. :)

@brianteeman
Copy link
Contributor

I was thinking that it might be easier for you if you rolled that into this?

@crystalenka
Copy link
Member Author

ahhh I see. Well, yours is already RTC so no reason to delay that fix while I figure out what is happening with the flex wrapping here. :) Thank you though

@Hackwar Hackwar added the bug label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 4.3-dev May 2, 2023 16:29
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.3-dev.

@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:44
@HLeithner HLeithner changed the title Multiple Media Manager Fixes [4.4] Multiple Media Manager Fixes Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Conflicting Files NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants