-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Multiple Media Manager Fixes #39266
base: 4.4-dev
Are you sure you want to change the base?
Conversation
In cases when multiple media sources are defined, it's hard to navigate any but the first media source. By making each media source a disclosure element, a user can now easily jump between media sources without scrolling for forever.
Folders did not get any kind of styles on hover before. Now they do.
Previously, long file names would stretch the sidebar instead of wrapping or being truncated. This makes file names truncated as they were originally intended to (from what I can tell of the original CSS).
Before there was no max height, so the folder list would not scroll until you reached the bottom of the image list (which can be quite a while). Now each media source has a reasonable max height and scrolls independently. Plus, if there are multiple media sources, they no longer stack on top of each other as you scroll.
No longer gets stuck at the top of the content.
Funky flex bugs happening when you switch folders or show/hide the main joomla sidebar menu. Marking this as draft until I can address. Sigh. If anyone wants to give those particular issues a try then they're welcome to. |
There is also #39222 |
I just saw that but I don't think there is a conflict, it's still a good change. :) |
I was thinking that it might be easier for you if you rolled that into this? |
ahhh I see. Well, yours is already RTC so no reason to delay that fix while I figure out what is happening with the flex wrapping here. :) Thank you though |
This pull request has been automatically rebased to 4.3-dev. |
This pull request has been automatically rebased to 4.4-dev. |
Closes issues #39126, #39078, possibly others.
Summary of Changes
What started as something straightforward ended up fixing a few things... it's a couple small fixes so it made more sense to group them.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
A much nicer experience.
Known issues
The list view. It's a mess, both before and after this PR. I will address it in another PR at a separate time because there are a lot of things that need to be improved.
That being said, it shouldn't be worse after this PR, so please let me know if there are new issues in the list view that do not exist before applying this PR.
Link to documentations
Please select: