Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix background color in form select #41626

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Sep 6, 2023

Pull Request for Issue #41571 (part)

Summary of Changes

Fix colors missing on select boxes in non-chosen form fields

Testing Instructions

See screenshots in the original issue - I used the edit menu item for the form select dropdowns per the original issue - but any form select that isn't chosen will do.

Note as this is a SCSS change patchtester will not work you'll need to download a package

Actual result BEFORE applying this Pull Request

Field renders but dropdown selector doesn't have a background

Expected result AFTER applying this Pull Request

Form field renders with background

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 6, 2023
@HLeithner HLeithner merged commit 0f69337 into joomla:5.0-dev Sep 7, 2023
@HLeithner
Copy link
Member

thx

@wilsonge wilsonge deleted the fix/select-dropdown-color branch September 7, 2023 08:23
@wilsonge wilsonge added this to the Joomla! 5.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants