New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Convert mod_feed to service provider #42215
Conversation
I have tested this item ✅ successfully on c7773b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215. |
I have tested this item ✅ successfully on 9e552c8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215. |
I have tested this item ✅ successfully on 9e552c8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215. |
Deprecate static function getFeed() in FeedHelper and replace with non static function
Thank you! |
Still one more comment, see file: line 65: I expected, just like with other recent PRs, eg #42792 Is there a reason for that? |
Summary of Changes
Converts the feed site module to service provider
Testing Instructions
feed
Note: system test added
Actual result BEFORE applying this Pull Request
module works
Expected result AFTER applying this Pull Request
module works
Link to documentations
Please select: