Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_feed to service provider #42215

Merged
merged 10 commits into from Feb 27, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Oct 24, 2023

Summary of Changes

Converts the feed site module to service provider

Testing Instructions

  • create site module feed
  • check site output

Note: system test added

Actual result BEFORE applying this Pull Request

module works
image

Expected result AFTER applying this Pull Request

module works
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@ceford
Copy link
Contributor

ceford commented Oct 27, 2023

I have tested this item ✅ successfully on c7773b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

@laoneo laoneo self-assigned this Oct 27, 2023
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9e552c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

@crimle
Copy link

crimle commented Feb 24, 2024

I have tested this item ✅ successfully on 9e552c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 25, 2024
@bembelimen bembelimen merged commit 3073ec7 into joomla:5.1-dev Feb 27, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@bembelimen
Copy link
Contributor

Thank you!

@sandewt
Copy link
Contributor

sandewt commented Feb 28, 2024

Still one more comment, see file:
modules/mod_feed/src/Helper/FeedHelper.php

line 65:
deprecated DEPLOY_VERSION will be removed in 7.0

I expected, just like with other recent PRs, eg #42792
deprecated DEPLOY_VERSION will be removed in 6.0

Is there a reason for that?

@heelc29 heelc29 deleted the 5.1/modules/site/feed branch March 31, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet