Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_wrapper to service provider #42792

Merged
merged 7 commits into from Feb 25, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the wrapper module to service provider.

Testing Instructions

  1. Make sure you have site module mod_wrapper published and configured
  2. You should see module output on frontend

mod_wrapper

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@sandewt
Copy link
Contributor

sandewt commented Feb 12, 2024

public static function getParams(&$params)

public static function getParams(&$params) is deprecated will be removed in 6.0
Please change this function to a non-static function.

@joomlaweby
Copy link
Contributor Author

public static function getParams(&$params) is deprecated will be removed in 6.0 Please change this function to a non-static function.

@sandewt resolved..thanks for review

@fgsw
Copy link

fgsw commented Feb 13, 2024

I have tested this item ✅ successfully on 62151be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

@ceford
Copy link
Contributor

ceford commented Feb 21, 2024

I have tested this item ✅ successfully on 4706e0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 4706e0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 25, 2024
@LadySolveig LadySolveig merged commit 169218b into joomla:5.1-dev Feb 25, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 25, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also testing and review @sandewt @fgsw @viocassel @ceford

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants