Skip to content

[5.1] Use Dialog for Batch windows - #42328

Merged
LadySolveig merged 12 commits into
joomla:5.1-devfrom
Fedik:popup-batch2
Nov 16, 2023
Merged

LadySolveig merged 12 commits into
joomla:5.1-devfrom
Fedik:popup-batch2

Conversation

@Fedik

@Fedik Fedik commented Nov 9, 2023

Copy link
Copy Markdown
Member

Summary of Changes

Use Dialog for Batch windows
The same as #40359 but for rest of Batch buttons.

Testing Instructions

Run npm install
Test Batch dialog for:

  • banners
  • contacts
  • newsfeeds
  • fields
  • field groups
  • menus
  • modules
  • tags
  • users

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: [5.0] Toolbar popup button Manual#184
  • No documentation changes for manual.joomla.org needed

References:

Comment thread build/media_source/com_fields/js/admin-fields-default-batch.es6.js Outdated
…6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@Quy

Quy commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 6b7061f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

1 similar comment
@viocassel

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 6b7061f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

@alikon

alikon commented Nov 11, 2023

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 11, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Nov 15, 2023
@LadySolveig
LadySolveig merged commit 3f48dad into joomla:5.1-dev Nov 16, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 16, 2023
@LadySolveig

Copy link
Copy Markdown
Contributor

Thank you for your work @Fedik !
And of course many thanks to our testers and @viocassel @Quy and @dgrammatiko for the review.

@Fedik
Fedik deleted the popup-batch2 branch November 16, 2023 08:11
richard67 added a commit to richard67/joomla-cms that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants