Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for Batch windows #42328

Merged
merged 12 commits into from Nov 16, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 9, 2023

Summary of Changes

Use Dialog for Batch windows
The same as #40359 but for rest of Batch buttons.

Testing Instructions

Run npm install
Test Batch dialog for:

  • banners
  • contacts
  • newsfeeds
  • fields
  • field groups
  • menus
  • modules
  • tags
  • users

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: [5.0] Toolbar popup button Manual#184
  • No documentation changes for manual.joomla.org needed

References:

…6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@Quy
Copy link
Contributor

Quy commented Nov 10, 2023

I have tested this item ✅ successfully on 6b7061f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6b7061f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

@alikon
Copy link
Contributor

alikon commented Nov 11, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 11, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Nov 15, 2023
@LadySolveig LadySolveig merged commit 3f48dad into joomla:5.1-dev Nov 16, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 16, 2023
@LadySolveig
Copy link
Contributor

Thank you for your work @Fedik !
And of course many thanks to our testers and @viocassel @Quy and @dgrammatiko for the review.

@Fedik Fedik deleted the popup-batch2 branch November 16, 2023 08:11
richard67 added a commit to richard67/joomla-cms that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants