Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_loginsupport to service provider #42827

Merged
merged 4 commits into from Feb 24, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the login support module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_loginsupport published and configured
  2. You should see module output on administrator login page

mod_loginsupport

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Feb 21, 2024

I have tested this item ✅ successfully on 2c3a20a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42827.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 2c3a20a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42827.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42827.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 21, 2024
@eddiekonczal
Copy link

I have tested this item ✅ successfully on 2c3a20a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42827.

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 24, 2024
@LadySolveig LadySolveig merged commit 164724b into joomla:5.1-dev Feb 24, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also for testing @fgsw @viocassel @eddiekonczal

@joomlaweby
Copy link
Contributor Author

Many thanks for reviewing and testing to @fgsw @viocassel @eddiekonczal @LadySolveig !

@richard67
Copy link
Member

Many thanks for reviewing and testing to @fgsw @viocassel @eddiekonczal @LadySolveig !

And to me not?

@LadySolveig
Copy link
Contributor

Special thanks to @richard67 for your enduring support! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants