Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Add missing Toggle inline help button to module modal #43599

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Jun 2, 2024

PARTIAL Pull Request for Issue #43501 .

Summary of Changes

When selecting a module in the module assignment tab of a menu item the module is opened in a modal.
Unlike the regular module display there is no toggle inline help button

Testing Instructions

Open any menu item, go to the module assignment tab and select any module

Actual result BEFORE applying this Pull Request

no toggle inline help button

Expected result AFTER applying this Pull Request

toggle inline help button is present

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jun 4, 2024

I have tested this item ✅ successfully on 835086e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43599.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jun 5, 2024

I have tested this item ✅ successfully on 835086e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43599.

@alikon
Copy link
Contributor

alikon commented Jun 5, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43599.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 5, 2024
@Quy Quy added the PR-5.2-dev label Jun 5, 2024
@pe7er pe7er self-assigned this Jun 10, 2024
@pe7er pe7er enabled auto-merge (squash) June 11, 2024 07:56
@pe7er pe7er merged commit b115247 into joomla:5.2-dev Jun 11, 2024
3 of 4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 11, 2024
@pe7er
Copy link
Contributor

pe7er commented Jun 11, 2024

Thanks @brianteeman !

@brianteeman brianteeman deleted the toggle-help branch June 11, 2024 15:43
@Quy Quy added this to the Joomla! 5.2.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants