New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing: Standard-behavior for components #5604
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponentrouteradvanced
…ms into componentrulesitemid
…omponentrouteradvanced
…ms into componentrulesitemid
Fix CS issues that was found by Travis
…s pretty complex and throws errors in our testing environment
…into com_content_router_legacy
…-cms into com_content_router_legacy
…omponentrouteradvanced
…iews in JComponentRouterAdvanced
…omponentrouteradvanced
…lasses except for JComponentRouterAdvanced
…ng unittests for JComponentRouterAdvanced
…ms into componentrulesitemid
…into com_content_router_legacy
Conflicts: administrator/language/en-GB/en-GB.mod_status.ini
Composer update for Joomla Framework packages and PHPUnit
…omponentrulesstandard Conflicts: tests/unit/suites/libraries/cms/router/JRouterSiteTest.php
I've combined the changes from this and all other routing related PRs into a new PR: #7615 Please review and comment in the new PR. I'm closing this one, so that we can focuse on the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a generic rule for standard behavior of components which routers extend from JComponentRouterAdvanced.
How to test
Apply this change
Change the router of com_content by replacing the code with the following:
Comment line 69 and 123 from /components/com_content/helpers/route.php to disable the lookup of the Itemid there.
See that it creates sane URLs and that those URLs point to the right place.
Issues
This requires that #5446 and all depending requests are merged first. (You can still test this PR, since all changes from those PRs are included into this one.)
This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors