[Imp] Implementing Alert when deleting items #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Language strings looks good ;) |
|
I have tested this item ✅ successfully on d2952d8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8995. |
|
Looks fine from review. |
|
I have tested this item ✅ successfully on d2952d8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8995. |
1 similar comment
|
I have tested this item ✅ successfully on d2952d8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8995. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8995. |
wilsonge
added a commit
that referenced
this pull request
Jan 27, 2016
[Imp] Implementing Alert when deleting items
infograf768
added a commit
to infograf768/weblinks
that referenced
this pull request
Jan 28, 2016
Similar to joomla/joomla-cms#8995 implemented in core.
This was referenced Jan 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR display an Alert to confirm deletion of items.
It works for the Buttons:
Delete
Empty trash
Uninstall
Only 2 new language strings.
com_media is not taken care of in this PR.
To test, patch and try to delete stuff via the buttons above in various list pages in admin.
Example in the Users interface:
Note: Brian already looked at the new lang strings.