--commits doesn't return the correct exit code #27
Labels
bug
User-facing bugs
Comments
This was referenced Apr 25, 2017
jorisroovers
pushed a commit
that referenced
this issue
Apr 25, 2017
The 0.8.2 release brings minor improvements, bugfixes and some under-the-hood changes. Special thanks to tommyip for his contributions. - --extra-path now also accepts a file path (in the past only directory paths where accepted). Thanks to tommyip for implementing this! - gitlint will now show more information when using the --debug flag. This is initial work and will continue to be improved upon in later releases. - Bugfixes: - #24: --commits doesn't take commit specific config into account - #27: --commits returns the wrong exit code - Development: better unit and integration test coverage for --commits Full Release details in CHANGELOG.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The exit code of gitlint represents the number of found violations (up to 252) as documented here : http://jorisroovers.github.io/gitlint/#exit-codes
When linting multiple
--commits, gitlint returns the number of violations found in the last commit message, not e.g. the total count of violations in all linted messages. This is especially problematic in case there are no violations in the last linted commit message as gitlint will exit with an exit code of 0, even though violations might have been found in other commits. This breaks CI scripts depending on the exit code.The text was updated successfully, but these errors were encountered: