Updates to type annotation/assertion after discussion/review #167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 83.01% 83.17% +0.15%
==========================================
Files 9 9
Lines 2126 2134 +8
==========================================
+ Hits 1765 1775 +10
+ Misses 361 359 -2
Continue to review full report at Codecov.
|
| %% adjusts type checking accordingly. The macros are supplied only for | ||
| %% convenience. | ||
| %% | ||
| -compile({inline, ['::'/2, ':::'/2]}). |
There was a problem hiding this comment.
It's really helpful that you've written this documentation. I think it would be even more helpful if you further clarified the distinction between :: and :::. Right now it's not clear which one does annotation and which does assertion.
There was a problem hiding this comment.
Oh, that's true.
| io:format("The type annotation ~p on line ~p is not a valid type~n", | ||
| [TypeStr, erl_anno:line(P)]); | ||
| [erl_pp:expr(TypeLit), line_no(TypeLit)]); |
There was a problem hiding this comment.
you could add maybe_format_column too
There was a problem hiding this comment.
Maybe. I thought it can be done when column is added to all error messages in a uniform way. One function call format_location would be preferable.
No problem. The merged part can be used already. I'm happy you like it. :-) |
zuiderkwast
force-pushed
the
annotate
branch
from
21e1e79
to
e76cc59
Compare
zuiderkwast
force-pushed
the
annotate
branch
from
e76cc59
to
2a4d3ce
Compare
#166 got merged so here are the discussed updates in a separate PR