do not normalize types recursively (#fixes 322) #323
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
recursive_types.erl
example, - the problem has been tracked down to recursive normalization of types intypechecker:normalize/2
when normalizing type aliases (user defined types).Stop recursive normalization is a possible fix against going into infinite loop.
Restricting normalization this way, however, makes
type_pattern:f
example fail (because the "inner alias" is not expanded/normalized anymore). - Moving it intoknown_problems
then.While
recursive_types/unwrap/1
from #322 stops falling into the infinite loop of normalization, it's not treated as well typed by Gradualizer - adding it toknown_problems
too.A bit more context about
recursive_types
example: a similar example is accepted by Typed Racket as well-typed: