Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI support #41

Closed
josefs opened this issue Oct 3, 2018 · 5 comments
Closed

Add CI support #41

josefs opened this issue Oct 3, 2018 · 5 comments
Assignees

Comments

@josefs
Copy link
Owner

josefs commented Oct 3, 2018

We have a decent test suite. It's be nice to leverage this by adding CI support. I have good experience with travis-ci but I'm interested in

We also have the possibility to run dialyzer if we implement CI support. Do people think that would be a good idea? I personally think it's be good to keep Gradualizer free from dialyzer warnings, but I'm too lazy to run it frequently. However, @gomoripeti runs it every now and again and finds useful improvements.

@gomoripeti
Copy link
Collaborator

I usually run make check which includes test, dialyze and gradualize (because it's much easier to type, I especially have issues with dialyzer :) ) Unfortunately self-gradualizer currently crashes, so that should be excluded on CI for now. OTOH would be good to have a coverage report either in the log as plain text or exported to some fancy service like coveralls.io

@gomoripeti
Copy link
Collaborator

As of master 0c702ab self-gradualizing does not crash any more 🎉 so can be included in the CI as a crash-test.

@Zalastax
Copy link
Collaborator

It seems like it's easier to get code coverage reports if rebar3 is used: https://erlang.mk/guide/coverage.html, https://www.rebar3.org/docs/running-tests#section-code-coverage

@Zalastax
Copy link
Collaborator

@zuiderkwast
Copy link
Collaborator

make tests COVER=1 creates an HTML coverage report using cover. Rebar probably does the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants