Skip to content

Refactor: move argument parsing out of josh-proxy.rs, define struct #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2022
Merged

Refactor: move argument parsing out of josh-proxy.rs, define struct #1019

merged 6 commits into from
Nov 11, 2022

Conversation

vlad-ivanov-name
Copy link
Collaborator

@vlad-ivanov-name vlad-ivanov-name commented Nov 11, 2022 •
edited
Loading

This was referenced Nov 11, 2022
Closed
Closed
Closed
Closed
Closed
@vlad-ivanov-name
SSH support, part 1
889f211 
* add a custom shell for use with SSH
* add an RPC interface for running commands from the main process
* add an endpoint where git-upload-pack launch can be requested
* prepare a multi-service docker image
* add a userland ssh server (only for development and testing)

Change: If3ace8e012c5608d5f589589b7d4931dd6a9e185

commit-id:e2721eb4
@vlad-ivanov-name
Check if repo is blocked before checking auth
050f1c8 
Change: I1b168057833c2666b1b696367872f7c0fb79100e

commit-id:cae15f45
@vlad-ivanov-name
Make auth optional in make_meta_config
3a6ef50 
Change: I61252ed70c0ad0eb128f95a06538e96049509187

commit-id:bd5114ff
@vlad-ivanov-name
Check for blocked repos in SSH RPC
dfac6d0 
Change: I7f51aac51b166f0bd85ec51a934711be129558c8

commit-id:51da9612
@vlad-ivanov-name
Refactor: use a sum type instead of a bool to indicate need for auth
f27f255 
This makes it less confusing and more readable

Change: I91c0784beda86e9d66bf62c77b0e568a3811432c

commit-id:8b1d1b05
@vlad-ivanov-name vlad-ivanov-name force-pushed the pr/vlad-ivanov-name/ssh/8b1d1b05 branch from 0cc2642 to f27f255 Compare November 11, 2022 09:37
@vlad-ivanov-name vlad-ivanov-name force-pushed the pr/vlad-ivanov-name/ssh/1a3f8cfc branch 2 times, most recently from 86e8389 to 96c4063 Compare November 11, 2022 09:40
@vlad-ivanov-name
Refactor: move argument parsing out of josh-proxy.rs, define struct
bb0798b 
* Also, support ssh:// remote argument

commit-id:1a3f8cfc
@vlad-ivanov-name vlad-ivanov-name force-pushed the pr/vlad-ivanov-name/ssh/1a3f8cfc branch from 96c4063 to bb0798b Compare November 11, 2022 10:19
@vlad-ivanov-name vlad-ivanov-name changed the base branch from pr/vlad-ivanov-name/ssh/8b1d1b05 to master November 11, 2022 11:30
@vlad-ivanov-name vlad-ivanov-name merged commit a413366 into master Nov 11, 2022
@vlad-ivanov-name vlad-ivanov-name deleted the pr/vlad-ivanov-name/ssh/1a3f8cfc branch November 11, 2022 11:30
@vlad-ivanov-name vlad-ivanov-name restored the pr/vlad-ivanov-name/ssh/1a3f8cfc branch November 11, 2022 11:30
@vlad-ivanov-name vlad-ivanov-name deleted the pr/vlad-ivanov-name/ssh/1a3f8cfc branch November 15, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-schilling christian-schilling christian-schilling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-ivanov-name @christian-schilling